liza/Questionable
liza/Questionable
2
1
Fork 26
Code Pull Requests 2 Releases 95 Activity

[SB][Allied Society][Intersocietal Quests] Added the Intersocietal questline #128

Open
plogon_enjoyer wants to merge 1 commits from plogon_enjoyer/Questionable:sb-intersocietal into master
pull from: plogon_enjoyer/Questionable:sb-intersocietal
merge into: liza:master
Conversation 0 Commits 1 Files Changed 4 +563
plogon_enjoyer commented 2025-01-11 10:51:38 +00:00
Contributor
Copy Link
  • The Ananta Maid's Tail
  • Ruby Seas under Ruby Skies
  • FIsh in a Barrel
  • What a Wonder-full World
- The Ananta Maid's Tail - Ruby Seas under Ruby Skies - FIsh in a Barrel - What a Wonder-full World
plogon_enjoyer added 1 commit 2025-01-11 10:51:39 +00:00 
- The Ananta Maid's Tail
- Ruby Seas under Ruby Skies
- FIsh in a Barrel
- What a Wonder-full World
plogon_enjoyer reviewed 2025-01-11 10:54:21 +00:00
QuestPaths/4.x - Stormblood/Allied Societies/Intersocietal Quests/3161_The Ananta Maid's Tail.json
@ -0,0 +160,4 @@
]
},
{
"Sequence": 255,
plogon_enjoyer commented 2025-01-11 10:54:21 +00:00
Author
Contributor
Copy Link

Hi @liza for the last sequence in this quest, it completes by using the item. Still, I added the CompleteQuest interaction so it still follows the schema, and also we can have a reference on the next quest. However, with the quest effectively complete before this step, I don't think it could automatically proceed with the next one.

Hi @liza for the last sequence in this quest, it completes by using the item. Still, I added the `CompleteQuest` interaction so it still follows the schema, and also we can have a reference on the next quest. However, with the quest effectively complete before this step, I don't think it could automatically proceed with the next one.
liza commented 2025-01-11 16:04:27 +00:00
Owner
Copy Link

You can use CompleteQuest as of ad76ccf057 (as you can see in Interact.cs, it already doesn't interact normally with a CompleteQuest step if ItemId is set)

You can use `CompleteQuest` as of https://git.carvel.li/liza/Questionable/commit/ad76ccf05798cb6d6a3771e42aeb34103b23d614 (as you can see in Interact.cs, it already doesn't interact normally with a CompleteQuest step if ItemId is set)
plogon_enjoyer commented 2025-01-13 18:23:31 +00:00
Author
Contributor
Copy Link

Great! I'll update this branch and will let you know once it's done!

Great! I'll update this branch and will let you know once it's done!
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u sb-intersocietal:plogon_enjoyer-sb-intersocietal
git checkout plogon_enjoyer-sb-intersocietal
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: liza/Questionable#128
No description provided.
Delete Branch "plogon_enjoyer/Questionable:sb-intersocietal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?