liza/Questionable
liza/Questionable
2
1
Fork 18
Code Pull Requests 1 Releases 84 Activity

[EW][Job Quests][SGE] Added SGE job quests. #46

Merged
liza merged 7 commits from kaiserbh/Questionable:master into master 2024-09-16 15:05:41 +00:00
Conversation 2 Commits 7 Files Changed 11 +987 -5
kaiserbh commented 2024-09-15 00:32:45 +00:00
Contributor
Copy Link

I managed to add the last 3 of SGE job quests, I would have added the first 3 as well but I did them already so can't really check if it's going to work or not. Also modified the Action since SGE is a bit finicky, for some reason in combat it will always end up with Eukrasia buff, which disables Diagnosis.

I think there is a better way to do it? Maybe if we add like a json field for aura to check or aura to remove then just do that instead of doing it in the Action? Similar with SGE abilities, we will need a pre-action sort off. Something like Pre-Action field to cast eukrasia then afterwards cast Eukrasian Diagnosis etc..

That being said the current implementation works as well. Also this is my first time making a QuestPath so let me know if I can improve it or if there is anything wrong with it.

I managed to add the last 3 of SGE job quests, I would have added the first 3 as well but I did them already so can't really check if it's going to work or not. Also modified the Action since SGE is a bit finicky, for some reason in combat it will always end up with Eukrasia buff, which disables Diagnosis. I think there is a better way to do it? Maybe if we add like a json field for aura to check or aura to remove then just do that instead of doing it in the Action? Similar with SGE abilities, we will need a pre-action sort off. Something like Pre-Action field to cast eukrasia then afterwards cast Eukrasian Diagnosis etc.. That being said the current implementation works as well. Also this is my first time making a QuestPath so let me know if I can improve it or if there is anything wrong with it.
kaiserbh added 3 commits 2024-09-15 00:32:45 +00:00 
Only managed to add last 3 as I did the first 3 already.
Also updated the Action a bit, that way SGE doesn't get stuck when using diagnosis.
kaiserbh added 1 commit 2024-09-15 00:37:04 +00:00
liza commented 2024-09-15 11:01:27 +00:00
Owner
Copy Link

You can replay the first few quests for SGE with New Game Plus, if you want to add them.

Not sure if the Eukrasis bit is part of RSR or what; but it's fair game to remove it if it's problematic IMO.

You can replay the first few quests for SGE with New Game Plus, if you want to add them. Not sure if the Eukrasis bit is part of RSR or what; but it's fair game to remove it if it's problematic IMO.
👍 1
kaiserbh added 2 commits 2024-09-16 00:23:22 +00:00
kaiserbh commented 2024-09-16 00:24:03 +00:00
Author
Contributor
Copy Link

Done added the rest of SGE job quests. It should be completed now.

Done added the rest of SGE job quests. It should be completed now.
kaiserbh changed title from [EW][Job Quests][SGE] Added the last 3 of SGE job quests. to [EW][Job Quests][SGE] Added SGE job quests. 2024-09-16 00:34:35 +00:00
kaiserbh added 1 commit 2024-09-16 00:35:46 +00:00
liza merged commit 43b796561b into master 2024-09-16 15:05:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: liza/Questionable#46
No description provided.
Delete Branch "kaiserbh/Questionable:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?