liza/Questionable
liza/Questionable
2
1
Fork 18
Code Pull Requests 1 Releases 84 Activity

cacahuetes-minorupdate1 #17

Closed
cacahuetes wants to merge 2 commits from cacahuetes/Questionable:cacahuetes-minorupdate1 into master
pull from: cacahuetes/Questionable:cacahuetes-minorupdate1
merge into: liza:master
Conversation 2 Commits 2 Files Changed 2 +166 -141
cacahuetes commented 2024-08-20 09:36:30 +00:00
Contributor
Copy Link

added ferry skipper to conjurer quest so that aetheryte isn't required to east shroud.

Added a missing interaction point in Salvaging MSQ quest

added ferry skipper to conjurer quest so that aetheryte isn't required to east shroud. Added a missing interaction point in Salvaging MSQ quest
cacahuetes added 2 commits 2024-08-20 09:36:31 +00:00
liza reviewed 2024-08-20 12:43:39 +00:00
QuestPaths/2.x - A Realm Reborn/Class Quests/WHM/91_Trial by Wind.json
@ -141,0 +46,4 @@
"AethernetShortcut": [
"[Gridania] Conjurers' Guild",
"[Gridania] Lancers' Guild"
]
liza commented 2024-08-20 12:43:39 +00:00
Owner
Copy Link

I would probably add a

SkipCondition: 
  StepIf:
    AetheryteUnlocked: East Shroud - Hawthorne Hut

so that it'll use the aetheryte if it's unlocked.

I would probably add a ``` SkipCondition: StepIf: AetheryteUnlocked: East Shroud - Hawthorne Hut ``` so that it'll use the aetheryte if it's unlocked.
liza commented 2024-08-20 12:45:09 +00:00
Owner
Copy Link

Just as a minor point of advice: I think if it's unrelated quest lines (such as MSQ & WHM quests here), it'd be better to have them as separate PRs since they'll have to be checked separately anyhow.

If they'd both be e.g. MSQ quests (and not super far apart, like changing the Sastasha quest + changing a HW quest), having them only as one PR would be fine.

Just as a minor point of advice: I think if it's unrelated quest lines (such as MSQ & WHM quests here), it'd be better to have them as separate PRs since they'll have to be checked separately anyhow. If they'd both be e.g. MSQ quests (and not super far apart, like changing the Sastasha quest + changing a HW quest), having them only as one PR would be fine.
cacahuetes commented 2024-08-20 12:46:10 +00:00
Author
Contributor
Copy Link

ok got it! want to reject this PR and I will seperate them out/ add the skip condition?

ok got it! want to reject this PR and I will seperate them out/ add the skip condition?
cacahuetes closed this pull request 2024-08-20 12:46:10 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: liza/Questionable#17
No description provided.
Delete Branch "cacahuetes/Questionable:cacahuetes-minorupdate1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?