AddQuestPriorityIPC #148

Open
pot0to wants to merge 13 commits from pot0to/Questionable:AddQuestPriorityIPC into master
Contributor
No description provided.
pot0to added 9 commits 2025-03-01 20:50:04 +00:00
pot0to added 1 commit 2025-03-01 20:51:16 +00:00
pot0to added 1 commit 2025-03-01 20:53:27 +00:00
Author
Contributor

sorry liza :> i really really really appreciate you

sorry liza :> i really really really appreciate you
pot0to added 1 commit 2025-03-01 21:03:07 +00:00
liza reviewed 2025-03-01 21:44:51 +00:00
@ -122,6 +128,13 @@ internal sealed class QuestionableIpc : IDisposable
return true;
}
private bool ImportQuestPriority(string encodedQuestPriority)
Owner

This IPC should take a List<string>, which should be converted to ElementIds; and not parse a preset string. That's more like, a /qst import command type of thing; and probably be called AddPriorityQuests.

There should also be a ClearPriorityQuests IPC.

This IPC should take a `List<string>`, which should be converted to `ElementId`s; and not parse a preset string. That's more like, a `/qst import` command type of thing; and probably be called `AddPriorityQuests`. There should also be a `ClearPriorityQuests` IPC.
Author
Contributor

So I specifically wanted an IPC that is able to use a preset exported from this "Export to Clipboard" button. The goal is so I can build presets that include all the beast tribe quests, including both Main and Daily quests and run it daily using SND. Maybe there are other SND use cases for importable presets, but I'm not sure. Are you saying that you don't want to add this kind of IPC, and would prefer if I instead add something that only goes by List<string> quest ids?

image.png
So I specifically wanted an IPC that is able to use a preset exported from this "Export to Clipboard" button. The goal is so I can build presets that include all the beast tribe quests, including both Main and Daily quests and run it daily using SND. Maybe there are other SND use cases for importable presets, but I'm not sure. Are you saying that you don't want to add this kind of IPC, and would prefer if I instead add something that only goes by `List<string>` quest ids? <img width="297" alt="image.png" src="attachments/c6ea2e62-f5d7-4d7e-9607-391d20e1e9c0">
Owner

Oh, makes sense, I guess.

Oh, makes sense, I guess.
pot0to added 1 commit 2025-03-02 03:35:39 +00:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u AddQuestPriorityIPC:pot0to-AddQuestPriorityIPC
git checkout pot0to-AddQuestPriorityIPC
Sign in to join this conversation.
No Reviewers
No Label
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liza/Questionable#148
No description provided.