liza/Questionable
liza/Questionable
2
1
Fork 26
Code Pull Requests 2 Releases 99 Activity

add StartQuest ipc #133

Merged
liza merged 2 commits from croizat/Questionable:ipc into master 2025-02-05 17:02:54 +00:00
Conversation 0 Commits 2 Files Changed 1 +17 -1
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2378bb693c - Show all commits

18
Questionable/External/QuestionableIpc.cs vendored
View File

@ -4,6 +4,7 @@ using System.Linq;
using Dalamud.Plugin;
using Dalamud.Plugin.Ipc;
using Questionable.Controller;
using Questionable.Model.Questing;
using Questionable.Windows.QuestComponents;
namespace Questionable.External;
@ -17,10 +18,11 @@ internal sealed class QuestionableIpc : IDisposable
private readonly ICallGateProvider<bool> _isRunning;
private readonly ICallGateProvider<string?> _getCurrentQuestId;
private readonly ICallGateProvider<List<string>> _getCurrentlyActiveEventQuests;
private readonly ICallGateProvider<string, bool> _startQuest;
public QuestionableIpc(
QuestController questController,
EventInfoComponent eventInfoComponent,
EventInfoComponent eventInfoComponent, QuestRegistry questRegistry,
IDalamudPluginInterface pluginInterface)
{
_isRunning = pluginInterface.GetIpcProvider<bool>(IpcIsRunning);
@ -34,11 +36,25 @@ internal sealed class QuestionableIpc : IDisposable
pluginInterface.GetIpcProvider<List<string>>(IpcGetCurrentlyActiveEventQuests);
_getCurrentlyActiveEventQuests.RegisterFunc(() =>
eventInfoComponent.GetCurrentlyActiveEventQuests().Select(q => q.ToString()).ToList());
_startQuest = pluginInterface.GetIpcProvider<string, bool>("Questionable.StartQuest");
_startQuest.RegisterFunc((string questId) => StartQuest(questController, questRegistry, questId));
}
private static bool StartQuest(QuestController qc, QuestRegistry qr, string questId)
{
if (ElementId.TryFromString(questId, out var elementId) && elementId != null && qr.TryGetQuest(elementId, out var quest))
{
liza marked this conversation as resolved
liza commented 2025-02-05 16:24:55 +00:00
Review
Copy Link

You can use qr.IsKnownQuest(elementId) instead of qr.TryGetQuest(elementId, out var quest)

You can use `qr.IsKnownQuest(elementId)` instead of `qr.TryGetQuest(elementId, out var quest)`
croizat commented 2025-02-05 16:54:49 +00:00
Review
Copy Link

Well I need the out value to pass to SetNextQuest, no? Unless there's a method I'm missing that would only take in an elementid

Well I need the `out` value to pass to `SetNextQuest`, no? Unless there's a method I'm missing that would only take in an elementid
liza commented 2025-02-05 17:02:33 +00:00
Review
Copy Link

Oh, you're right.

Oh, you're right.
qc.SetNextQuest(quest);
qc.Start("IPCQuestSelection");
return true;
}
return false;
}
public void Dispose()
{
_startQuest.UnregisterFunc();
_getCurrentlyActiveEventQuests.UnregisterFunc();
_getCurrentQuestId.UnregisterFunc();
_isRunning.UnregisterFunc();