liza/Questionable
liza/Questionable
2
1
Fork 26
Code Pull Requests 2 Releases 99 Activity

add StartQuest ipc #133

Merged
liza merged 2 commits from croizat/Questionable:ipc into master 2025-02-05 17:02:54 +00:00
Conversation 0 Commits 2 Files Changed 1 +18 -1
croizat commented 2025-02-05 15:59:48 +00:00
Contributor
Copy Link
No description provided.
croizat added 1 commit 2025-02-05 15:59:48 +00:00
croizat added 1 commit 2025-02-05 16:14:50 +00:00
liza reviewed 2025-02-05 16:24:55 +00:00
Questionable/External/QuestionableIpc.cs
@ -38,1 +44,4 @@
private static bool StartQuest(QuestController qc, QuestRegistry qr, string questId)
{
if (ElementId.TryFromString(questId, out var elementId) && elementId != null && qr.TryGetQuest(elementId, out var quest))
liza commented 2025-02-05 16:24:55 +00:00
Owner
Copy Link

You can use qr.IsKnownQuest(elementId) instead of qr.TryGetQuest(elementId, out var quest)

You can use `qr.IsKnownQuest(elementId)` instead of `qr.TryGetQuest(elementId, out var quest)`
croizat commented 2025-02-05 16:54:49 +00:00
Author
Contributor
Copy Link

Well I need the out value to pass to SetNextQuest, no? Unless there's a method I'm missing that would only take in an elementid

Well I need the `out` value to pass to `SetNextQuest`, no? Unless there's a method I'm missing that would only take in an elementid
liza commented 2025-02-05 17:02:33 +00:00
Owner
Copy Link

Oh, you're right.

Oh, you're right.
liza marked this conversation as resolved
liza merged commit 7a47992792 into master 2025-02-05 17:02:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: liza/Questionable#133
No description provided.
Delete Branch "croizat/Questionable:ipc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?