liza/Influx
liza/Influx
1
0
Fork 1
Code Issues Pull Requests 1 Releases 23 Activity

Added auto enroll feature #1

Open
Asuna wants to merge 4 commits from Asuna/Influx:master into master
pull from: Asuna/Influx:master
merge into: liza:master
Conversation 0 Commits 4 Files Changed 5 +85 -23
Asuna commented 2025-01-05 17:26:04 +00:00
First-time contributor
Copy Link
  • Added help messages for commands
  • Added option to auto enroll any new character logged into. This will be useful for someone who has a lot of characters as they can just get auto retainer to start and it will auto enroll as it goes.

Visual studio required me to modify the solution file to actually get it to build. That's why you see that in there.

- Added help messages for commands - Added option to auto enroll any new character logged into. This will be useful for someone who has a lot of characters as they can just get auto retainer to start and it will auto enroll as it goes. Visual studio required me to modify the solution file to actually get it to build. That's why you see that in there.
Asuna added 1 commit 2025-01-05 17:26:04 +00:00 
Added option to auto enroll any new character logged into. This will be useful for someone who has a lot of characters as they can just get autoretainer to start and it will auto enroll as it goes.
liza reviewed 2025-01-06 00:35:29 +00:00
Influx/InfluxPlugin.cs Outdated
@ -69,0 +71,4 @@
HelpMessage = "Opens influx configuration"
});
_commandManager.AddHandler("/influx gil", new CommandInfo(ProcessCommand)
liza commented 2025-01-06 00:35:29 +00:00
Owner
Copy Link

I actually didn't know you could add commands with spaces, nevermind whether that is even processed correctly or not. Is there any other plugin that does this?

I actually didn't know you could add commands with spaces, nevermind whether that is even processed correctly or not. Is there any other plugin that does this?
Asuna commented 2025-01-06 17:47:26 +00:00
Author
First-time contributor
Copy Link

I saw this on the Doorbell plugin code. I was trying to find a way to include the help info in /xlplugins for it

The sample I saw to get that idea:
https://github.com/Aida-Enna/Doorbell/blob/main/Plugin.cs

I saw this on the Doorbell plugin code. I was trying to find a way to include the help info in /xlplugins for it The sample I saw to get that idea: https://github.com/Aida-Enna/Doorbell/blob/main/Plugin.cs
Asuna commented 2025-01-06 18:02:27 +00:00
Author
First-time contributor
Copy Link

I changed it to how Limiana does it for lifestream instead just now

I changed it to how Limiana does it for lifestream instead just now
liza reviewed 2025-01-06 00:36:27 +00:00
Influx/Windows/ConfigurationWindow.cs
@ -106,0 +106,4 @@
var refIncludeAll = _configuration.AutoEnrollCharacters;
if (ImGui.Checkbox("Auto enroll characters", ref refIncludeAll))
{
_configuration.AutoEnrollCharacters = refIncludeAll;
liza commented 2025-01-06 00:36:27 +00:00
Owner
Copy Link

This is probably missing a Save(true); if I'm not mistaken.

This is probably missing a `Save(true);` if I'm not mistaken.
Asuna commented 2025-01-06 17:46:37 +00:00
Author
First-time contributor
Copy Link

Thanks!! Fixed and will repush in a sec

Thanks!! Fixed and will repush in a sec
liza reviewed 2025-01-06 00:37:47 +00:00
Influx/Windows/ConfigurationWindow.cs Outdated
@ -138,3 +144,1 @@
ImGui.TextColored(ImGuiColors.DalamudRed,
"This character is currently excluded.");
if (ImGui.Button("Include current character"))
if (_configuration.AutoEnrollCharacters)
liza commented 2025-01-06 00:37:47 +00:00
Owner
Copy Link

The way this is phrased should probably be running in a IClientState.Login event, and not only when you open the configuration AND this tab in the UI.

The way this is phrased should probably be running in a `IClientState.Login` event, and not only when you open the configuration AND this tab in the UI.
Asuna commented 2025-01-06 17:46:51 +00:00
Author
First-time contributor
Copy Link

Thanks for the input, i made some modifications and will push in a minute

Thanks for the input, i made some modifications and will push in a minute
Asuna added 1 commit 2025-01-06 17:48:59 +00:00 
Changed the wording of the option itself
Fixed a bug where it wouldn't save to the config that you had auto enroll enabled.
Asuna added 1 commit 2025-01-06 17:51:20 +00:00
Asuna added 1 commit 2025-01-06 18:01:47 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u master:Asuna-master
git checkout Asuna-master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: liza/Influx#1
No description provided.
Delete Branch "Asuna/Influx:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?