liza/Questionable
liza/Questionable
2
1
Fork 18
Code Pull Requests 1 Releases 84 Activity

[HW][Vanu]Dailies and Story Quest #86

Merged
liza merged 7 commits from AnimaMachinae/Questionable:vanu-vanu into master 2024-10-24 14:16:26 +00:00
Conversation 2 Commits 7 Files Changed 8 +152 -152
1 changed files with 152 additions and 152 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 04c96efbe0 - Show all commits

6
QuestPaths/3.x - Heavensward/Allied Societies/Vanu Vanu/Dailies/2173_Endymion Disco.json
View File

@ -57,7 +57,7 @@
"Action": "Buffet (Sanuwa)",
"StopDistance": 3,
"$": "0 0 0 0 0 0 --> 1 0 0 0 0 16",
"CompletionQuestVariablesFlags": [1,null,null,null,null,16]
"CompletionQuestVariablesFlags": [null,null,null,null,null,16]
liza commented 2024-10-18 09:11:56 +00:00
Outdated
Review
Copy Link

It is -typically- enough to only include the last digit, from looking at this quest it looks like the '1/2/3' as first digit just count the completed actions (e.g. for display in UI) -- depending on which action you complete first, that will always count as [1, ...].

The last digit (16/80/112) typically represents which of the actions you've completed, so regardless of when you do the action at this position, it'll always add +16 to the last digit. This would typically just be [null, null, null, null, null, 16]

It is -typically- enough to only include the last digit, from looking at this quest it looks like the '1/2/3' as first digit just count the completed actions (e.g. for display in UI) -- depending on which action you complete first, that will always count as [1, ...]. The last digit (16/80/112) typically represents which of the actions you've completed, so regardless of when you do the action at this position, it'll always add +16 to the last digit. This would typically just be `[null, null, null, null, null, 16]`
AnimaMachinae commented 2024-10-18 12:38:20 +00:00
Outdated
Review
Copy Link

Interesting, besides the extraneous addition of the first number, that's how I initially had it, but when testing I ended up sitting in place waiting for a state that it never reached. There's likely an issue elsewhere as well then, but I should be able to test with a different quest sometime either today or shortly after, so I'll see what's up then.

Interesting, besides the extraneous addition of the first number, that's how I initially had it, but when testing I ended up sitting in place waiting for a state that it never reached. There's likely an issue elsewhere as well then, but I should be able to test with a different quest sometime either today or shortly after, so I'll see what's up then.
liza commented 2024-10-18 14:29:00 +00:00
Outdated
Review
Copy Link

The plugin only checks the parts that have any non-null value, so that would be odd.

The plugin only checks the parts that have any non-null value, so that would be odd.
},
{
"Position": {
@ -81,7 +81,7 @@
"Action": "Buffet (Sanuwa)",
"StopDistance": 3,
"$": "1 0 0 0 0 16 --> 2 0 0 0 0 80",
"CompletionQuestVariablesFlags": [2,null,null,null,null,80]
"CompletionQuestVariablesFlags": [null,null,null,null,null,64]
liza commented 2024-10-18 09:13:04 +00:00
Outdated
Review
Copy Link

This should probably be [null, null, null, null, null, 64], as this should only reflect the difference between now & the previous state (and 80 - 16 = 64).

This should probably be `[null, null, null, null, null, 64]`, as this should only reflect the difference between now & the previous state (and 80 - 16 = 64).
},
{
"Position": {
@ -105,7 +105,7 @@
"Action": "Buffet (Sanuwa)",
"StopDistance": 3,
"$": "2 0 0 0 0 80 --> 3 0 0 0 0 112",
"CompletionQuestVariablesFlags": [3,null,null,null,null,112]
"CompletionQuestVariablesFlags": [null,null,null,null,null,32]
liza commented 2024-10-18 09:13:25 +00:00
Outdated
Review
Copy Link

Similarily, this should be [null, null, null, null, null, 32]

Similarily, this should be `[null, null, null, null, null, 32]`
},
{
"Position": {