liza/Questionable
liza/Questionable
2
1
Fork 19
Code Pull Requests 3 Releases 85 Activity

[ShB][Allied Society][Pixies] Added remaining story quests #45

Merged
liza merged 3 commits from plogon_enjoyer/Questionable:pixie into master 2024-09-13 07:09:33 +00:00
Conversation 0 Commits 3 Files Changed 2 +4 -2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6f8693340c - Show all commits

6
QuestPaths/5.x - Shadowbringers/Allied Societies/Pixies/Story/3687_As the Heart Bids.json
View File

@ -151,11 +151,13 @@
"Z": 586.48047
},
"TerritoryId": 816,
"InteractionType": "SinglePlayerDuty",
"$": "Sequence 7 is the duty itself"
"InteractionType": "SinglePlayerDuty"
}
plogon_enjoyer marked this conversation as resolved
liza commented 2024-09-12 17:30:34 +00:00
Review
Copy Link

This looks like it's wrong. Quest sequences have nothing to do with instanced battles. It's more that Sequence 7 is probably cutscene-only, and thus will likely never be seen unless you (I think) DC in the middle of it.

Quite contrary: if you look at e.g. The Mountain that Strides, you'll see sequence 6 is a SinglePlayerDuty and sequence 7 is some other interaction afterwards.

For all intents and purposes, this should have

{
 "Sequence": 7
}

as separate sequence.

This looks like it's wrong. Quest sequences have nothing to do with instanced battles. It's more that Sequence 7 is probably cutscene-only, and thus will likely never be seen unless you (I think) DC in the middle of it. Quite contrary: if you look at e.g. `The Mountain that Strides`, you'll see sequence 6 is a SinglePlayerDuty and sequence 7 is some other interaction afterwards. For all intents and purposes, this should have ``` { "Sequence": 7 } ``` as separate sequence.
plogon_enjoyer commented 2024-09-13 06:45:22 +00:00
Review
Copy Link

Ohhh good point, as I was also running TextAdvance so the cutscene was naturally skipped. I'll update this now.

Ohhh good point, as I was also running `TextAdvance` so the cutscene was naturally skipped. I'll update this now.
plogon_enjoyer commented 2024-09-13 06:49:42 +00:00
Review
Copy Link

This is now updated in 6f8693340c

This is now updated in 6f8693340ce35e51c52a7ddd2c6bfd2199ca39cc
]
},
{
"Sequence": 7
},
{
"Sequence": 8,
"Steps": [