liza/Questionable
liza/Questionable
2
1
Fork 18
Code Pull Requests 1 Releases 84 Activity

[SB][Allied Society][Kojin] Added new story and daily quests #71

Merged
liza merged 8 commits from plogon_enjoyer/Questionable:kojin into master 2024-10-01 19:19:29 +00:00
Conversation 0 Commits 8 Files Changed 9 +735
plogon_enjoyer commented 2024-09-26 18:27:16 +00:00
Contributor
Copy Link

Added new story quest:

  • Under Wraps

Added new daily quests:

  • You Have the Rite
  • Pickles of Partnership
  • Little Kojin Lost
  • Much at Steak
  • Sand-sifting Specialist

Added new Action:

  • Inhale
Added new story quest: - Under Wraps Added new daily quests: - You Have the Rite - Pickles of Partnership - Little Kojin Lost - Much at Steak - Sand-sifting Specialist Added new Action: - Inhale
plogon_enjoyer added 1 commit 2024-09-26 18:27:16 +00:00 
- Best Served Foul
- A Real Pearler
- You Have the Rite
plogon_enjoyer added 1 commit 2024-09-28 08:16:52 +00:00 
- Pickles of Partnership
plogon_enjoyer added 5 commits 2024-09-28 18:26:19 +00:00 
- Under Wraps
- Little Kojin Lost
- Much at Steak
- Sand-sifting Specialist
plogon_enjoyer changed title from [SB][Allied Society][Kojin] Added new daily quests to [SB][Allied Society][Kojin] Added new story and daily quests 2024-09-28 18:26:41 +00:00
liza reviewed 2024-09-28 19:48:38 +00:00
QuestPaths/4.x - Stormblood/Allied Societies/Kojin/Dailies/2980_A Real Pearler.json Outdated
@ -0,0 +59,4 @@
"TerritoryId": 613,
"InteractionType": "Interact",
"Fly": true,
"RequiredQuestVariables": [null, [2, 9, 21], null, null, null, null]
liza commented 2024-09-28 19:48:38 +00:00
Owner
Copy Link

I genuinely don't understand what's happening with RequiredQuestVariables here (or in 'Best Served Foul') to be honest, and I'd recommend removing these two quests from the PR and splitting them off into a separate PR for now - at least from the looks of it, I won't be merging them without having tested them manually.

I genuinely don't understand what's happening with `RequiredQuestVariables` here (or in 'Best Served Foul') to be honest, and I'd recommend removing these two quests from the PR and splitting them off into a separate PR for now - at least from the looks of it, I won't be merging them without having tested them manually.
plogon_enjoyer commented 2024-09-29 16:17:26 +00:00
Author
Contributor
Copy Link

There are 3 points generated per instance of the quest. The numbers I've noticed here is that the 2nd variable starts from 1-9, then for each point interacted, it increments by 16. That's why some values may appear random, but they're basically a factor of 16, plus the initial value. In this instance you mentioned, 21 just means that it's the 2nd point taken when the variable is initially 5, since 5 + 16 is 21, with the third one having the value of 37.

So with that, would it be possible to implement a version of RequiredQuestVariables that defines the starting value of a variable, and then define if it increases by 1 (Low) or 16 (High). In my understanding, the current for of the Low/High check is that it always starts from 0. Anyway, I'll go ahead and separate these quest paths as per your comment.

There are 3 points generated per instance of the quest. The numbers I've noticed here is that the 2nd variable starts from 1-9, then for each point interacted, it increments by 16. That's why some values may appear random, but they're basically a factor of 16, plus the initial value. In this instance you mentioned, `21` just means that it's the 2nd point taken when the variable is initially `5`, since `5` + `16` is `21`, with the third one having the value of `37`. So with that, would it be possible to implement a version of `RequiredQuestVariables ` that defines the starting value of a variable, and then define if it increases by 1 (`Low`) or 16 (`High`). In my understanding, the current for of the `Low`/`High` check is that it always starts from `0`. Anyway, I'll go ahead and separate these quest paths as per your comment.
plogon_enjoyer commented 2024-09-29 16:21:27 +00:00
Author
Contributor
Copy Link

Just to add some details for Best Served Foul, it's much simpler that A Real Pearler. The variable just starts with either 34 or 35, then after the first point for the Combat/UseItem combo, it reduces by 16. That's why the possible 2nd point are either 18 or 19. I've retried this multiple multiple times, but I cannot get another initial value besides 34 or 35.

Just to add some details for `Best Served Foul`, it's much simpler that `A Real Pearler`. The variable just starts with either `34` or `35`, then after the first point for the `Combat`/`UseItem` combo, it reduces by `16`. That's why the possible 2nd point are either `18` or `19`. I've retried this multiple multiple times, but I cannot get another initial value besides `34` or `35`.
plogon_enjoyer commented 2024-09-29 16:25:20 +00:00
Author
Contributor
Copy Link

The following are removed in 7436f03199

  • Best Served Foul
  • A Real Pearler
The following are removed in 7436f03199ca0242d8eb8b6e272a976d5e03dab9 - Best Served Foul - A Real Pearler
plogon_enjoyer marked this conversation as resolved
plogon_enjoyer force-pushed kojin from 1dbc95b1a0 to f7ba64d34b 2024-09-29 16:08:01 +00:00 Compare
plogon_enjoyer added 1 commit 2024-09-29 16:24:20 +00:00 
- Best Served Foul
- A Real Pearler
liza merged commit 9139e8dd7b into master 2024-10-01 19:19:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: liza/Questionable#71
No description provided.
Delete Branch "plogon_enjoyer/Questionable:kojin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?