liza/Questionable
liza/Questionable
3
2
Fork 28
Code Pull Requests 6 Releases 104 Activity

AddingNewQuests #149

Merged
liza merged 10 commits from pot0to/Questionable:AddingNewQuests into master 2025-03-03 22:16:43 +00:00
Conversation 2 Commits 10 Files Changed 4 +400 -12
pot0to commented 2025-03-01 21:00:13 +00:00
Contributor
Copy Link
No description provided.
pot0to added 9 commits 2025-03-01 21:00:14 +00:00
liza reviewed 2025-03-01 22:30:57 +00:00
QuestPaths/4.x - Stormblood/Allied Societies/Namazu/Dailies/3121_Bearers Wanted.json Outdated
@ -1,6 +1,6 @@
{
"$schema": "https://git.carvel.li/liza/Questionable/raw/branch/master/QuestPaths/quest-v1.json",
"Author": "Theo",
"Author": "pot0to",
liza commented 2025-03-01 22:30:57 +00:00
Owner
Copy Link

This seems strange.

This seems strange.
liza reviewed 2025-03-01 22:31:37 +00:00
QuestPaths/4.x - Stormblood/Allied Societies/Namazu/Dailies/3121_Bearers Wanted.json Outdated
@ -62,13 +62,13 @@
"Fly": true,
"Land": true,
"Action": "Wasshoi",
"CompletionQuestVariablesFlags": [
liza commented 2025-03-01 22:31:36 +00:00
Owner
Copy Link

These are two completely different logic bits, I don't think Theo's usage of CompletionQuestVariablesFlags is wrong here; and RequiredQuestVariables should be added instead of replacing it.

These are two completely different logic bits, I don't think Theo's usage of `CompletionQuestVariablesFlags` is wrong here; and `RequiredQuestVariables` should be added instead of replacing it.
pot0to commented 2025-03-03 21:11:54 +00:00
Author
Contributor
Copy Link

I don't think CompletionQuestVariablesFlags will work here. This is a step where the game randomly assigns you 2 out of 4 locations to visit, and there are 6 possible combinations. If I understand this correctly, Theo's step 2/0 says 64 and 2/1 says 128, meaning it probably expects to complete them in that order. But if the game never assigns you location 2/0 and only gives you locations 2/1 and 2/2, then 2/1 will always get stuck. At least that is what happened to me, my quest path kept getting stuck

In other words, if the game assigns you locations 2/0 and 2/1, then the CompletionQuestVariableFlag for 2/1 should be 128. But if the game assigns you 2/1 and 2/2, then CompletionQuestVariableFlag for 2/1 should be 64. Since this can't be pinned down to a single number, I don't know if it'll work? (This is more or less speculation on my part based on what I think 64 and 128 mean here. I'll need to get this quest again to double check. But I do know I kept getting stuck last week when I ran this path.)

I don't think `CompletionQuestVariablesFlags` will work here. This is a step where the game randomly assigns you 2 out of 4 locations to visit, and there are 6 possible combinations. If I understand this correctly, Theo's step 2/0 says 64 and 2/1 says 128, meaning it probably expects to complete them in that order. But if the game never assigns you location 2/0 and only gives you locations 2/1 and 2/2, then 2/1 will always get stuck. At least that is what happened to me, my quest path kept getting stuck In other words, if the game assigns you locations 2/0 and 2/1, then the `CompletionQuestVariableFlag` for 2/1 should be 128. But if the game assigns you 2/1 and 2/2, then `CompletionQuestVariableFlag` for 2/1 should be 64. Since this can't be pinned down to a single number, I don't know if it'll work? (This is more or less speculation on my part based on what I think 64 and 128 mean here. I'll need to get this quest again to double check. But I do know I kept getting stuck last week when I ran this path.)
pot0to added 1 commit 2025-03-03 21:13:33 +00:00
liza merged commit ddfe98e8b2 into master 2025-03-03 22:16:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liza/Questionable#149
No description provided.
Delete Branch "pot0to/Questionable:AddingNewQuests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?