diff --git a/Directory.Build.targets b/Directory.Build.targets index 729f81b6..2e7016cb 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -1,5 +1,5 @@ - 4.16 + 4.17 diff --git a/Questionable/.editorconfig b/Questionable/.editorconfig index 140b119d..1eba5c1b 100644 --- a/Questionable/.editorconfig +++ b/Questionable/.editorconfig @@ -1015,3 +1015,7 @@ csharp_style_inlined_variable_declaration = true:suggestion csharp_style_deconstructed_variable_declaration = true:suggestion csharp_style_unused_value_assignment_preference = discard_variable:suggestion csharp_style_unused_value_expression_statement_preference = discard_variable:silent + +resharper_arrange_trailing_comma_in_multiline_lists_highlighting = none +resharper_redundant_if_else_block_highlighting = none +resharper_convert_to_primary_constructor_highlighting = hint diff --git a/Questionable/Controller/GameUi/InteractionUiController.cs b/Questionable/Controller/GameUi/InteractionUiController.cs index c5aa27c3..45333c2b 100644 --- a/Questionable/Controller/GameUi/InteractionUiController.cs +++ b/Questionable/Controller/GameUi/InteractionUiController.cs @@ -7,7 +7,6 @@ using Dalamud.Game.Addon.Lifecycle; using Dalamud.Game.Addon.Lifecycle.AddonArgTypes; using Dalamud.Game.ClientState.Objects; using Dalamud.Plugin.Services; -using FFXIVClientStructs.FFXIV.Client.Game; using FFXIVClientStructs.FFXIV.Client.Game.Event; using FFXIVClientStructs.FFXIV.Client.Game.InstanceContent; using FFXIVClientStructs.FFXIV.Client.Game.UI; @@ -22,11 +21,8 @@ using Questionable.Controller.Steps.Interactions; using Questionable.Data; using Questionable.Functions; using Questionable.Model; -using Questionable.Model.Common; using Questionable.Model.Gathering; using Questionable.Model.Questing; -using AethernetShortcut = Questionable.Controller.Steps.Shared.AethernetShortcut; -using EAetheryteLocationExtensions = Questionable.Model.Common.EAetheryteLocationExtensions; using Quest = Questionable.Model.Quest; using ValueType = FFXIVClientStructs.FFXIV.Component.GUI.ValueType; @@ -634,7 +630,7 @@ internal sealed class InteractionUiController : IDisposable } private unsafe bool HandleDefaultYesNo(AddonSelectYesno* addonSelectYesno, Quest quest, - IList dialogueChoices, string actualPrompt) + List dialogueChoices, string actualPrompt) { _logger.LogTrace("DefaultYesNo: Choice count: {Count}", dialogueChoices.Count); foreach (var dialogueChoice in dialogueChoices) diff --git a/Questionable/Controller/Steps/TaskCreator.cs b/Questionable/Controller/Steps/TaskCreator.cs index b96ed5be..915f7d57 100644 --- a/Questionable/Controller/Steps/TaskCreator.cs +++ b/Questionable/Controller/Steps/TaskCreator.cs @@ -25,7 +25,7 @@ internal sealed class TaskCreator var newTasks = scope.ServiceProvider.GetRequiredService>() .SelectMany(x => { - IList tasks = x.CreateAllTasks(quest, sequence, step).ToList(); + List tasks = x.CreateAllTasks(quest, sequence, step).ToList(); if (tasks.Count > 0 && _logger.IsEnabled(LogLevel.Trace)) { diff --git a/Questionable/Windows/OneTimeSetupWindow.cs b/Questionable/Windows/OneTimeSetupWindow.cs index 3db85089..128a2f1a 100644 --- a/Questionable/Windows/OneTimeSetupWindow.cs +++ b/Questionable/Windows/OneTimeSetupWindow.cs @@ -1,5 +1,6 @@ using System; using System.Collections.Generic; +using System.Collections.ObjectModel; using System.Linq; using Dalamud.Interface; using Dalamud.Interface.Colors; @@ -8,7 +9,6 @@ using Dalamud.Interface.Utility.Raii; using Dalamud.Plugin; using Dalamud.Utility; using ImGuiNET; -using LLib; using LLib.ImGui; using Microsoft.Extensions.Logging; using Questionable.External; @@ -44,7 +44,7 @@ internal sealed class OneTimeSetupWindow : LWindow new Uri("https://github.com/NightmareXIV/MyDalamudPlugins/raw/main/pluginmaster.json")), ]; - private static readonly IReadOnlyDictionary CombatPlugins = new Dictionary + private static readonly ReadOnlyDictionary CombatPlugins = new Dictionary { { Configuration.ECombatModule.BossMod,