From 03a438bc433061d3e2d5d817b6a76e8425683f20 Mon Sep 17 00:00:00 2001 From: Liza Carvelli Date: Mon, 3 Mar 2025 23:20:53 +0100 Subject: [PATCH] Version bump --- Directory.Build.targets | 2 +- Questionable.IpcTest/IpcTestPlugin.cs | 5 ++++- Questionable/External/QuestionableIpc.cs | 4 +++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Directory.Build.targets b/Directory.Build.targets index 0ef99fba..b07966ea 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -1,5 +1,5 @@ - 4.22 + 4.23 diff --git a/Questionable.IpcTest/IpcTestPlugin.cs b/Questionable.IpcTest/IpcTestPlugin.cs index 5d63aa1e..afa682cb 100644 --- a/Questionable.IpcTest/IpcTestPlugin.cs +++ b/Questionable.IpcTest/IpcTestPlugin.cs @@ -1,4 +1,5 @@ -using System.Globalization; +using System.Diagnostics.CodeAnalysis; +using System.Globalization; using System.Numerics; using Dalamud.Game.Command; using Dalamud.Game.Text.SeStringHandling; @@ -50,6 +51,8 @@ public sealed class IpcTestPlugin : IDalamudPlugin _commandManager.RemoveHandler("/qipc"); } + [SuppressMessage("ReSharper", "ClassNeverInstantiated.Local")] + [SuppressMessage("ReSharper", "UnusedAutoPropertyAccessor.Local")] private sealed class IpcStepData { public required string InteractionType { get; set; } diff --git a/Questionable/External/QuestionableIpc.cs b/Questionable/External/QuestionableIpc.cs index f1095f1e..417cea0e 100644 --- a/Questionable/External/QuestionableIpc.cs +++ b/Questionable/External/QuestionableIpc.cs @@ -7,6 +7,7 @@ using Dalamud.Plugin.Ipc; using JetBrains.Annotations; using Questionable.Controller; using Questionable.Functions; +using Questionable.Model; using Questionable.Model.Questing; using Questionable.Windows.QuestComponents; @@ -115,7 +116,7 @@ internal sealed class QuestionableIpc : IDisposable private bool IsQuestLocked(string questId) { if (ElementId.TryFromString(questId, out var elementId) && elementId != null && - _questRegistry.TryGetQuest(elementId, out var quest)) + _questRegistry.TryGetQuest(elementId, out _)) { return _questFunctions.IsQuestLocked(elementId); } @@ -124,6 +125,7 @@ internal sealed class QuestionableIpc : IDisposable public void Dispose() { + _isQuestLocked.UnregisterFunc(); _startSingleQuest.UnregisterFunc(); _startQuest.UnregisterFunc(); _getCurrentlyActiveEventQuests.UnregisterFunc();