Using Safety seems to disable trap location rendering even for following floors #18

New Issue

liza · 2023-04-12T16:55:05Z

KalasB commented

2023-04-12 16:55:05 +00:00

(Migrated from github.com)

In the newest version, using a pom of safety once stops the plogon from rendering traps on the next floors.
This behaviour did not occur using previous versions.

Noticed in PotD and EO so far. Have not tried HoH.

In the newest version, using a pom of safety once stops the plogon from rendering traps on the next floors. This behaviour did not occur using previous versions. Noticed in PotD and EO so far. Have not tried HoH.

syldrathecat commented

2023-04-12 17:23:49 +00:00

(Migrated from github.com)

Oh I am not the only one. I was trying to figure out if there was a conflicting plugin but disabling everything else doesn't seem to help.

The plugin recognizes all other chat-based triggers, but not "Floor X" to reset the sight/intuition state.

Oh I am not the only one. I was trying to figure out if there was a conflicting plugin but disabling everything else doesn't seem to help. The plugin recognizes all other chat-based triggers, but not "Floor X" to reset the sight/intuition state.

syldrathecat commented

2023-04-12 18:00:22 +00:00

(Migrated from github.com)

If I write this as a test script, it shows the logic for creating the floor change regex is seemingly not functioning anymore:

uint id = 7270;
var str = Svc.Data.GetExcelSheet<LogMessage>()?.GetRow(id)?.Text?.ToString() ?? "Unknown";
var str2 = new Regex("^" + str.Replace("\u0002 \u0003\ufffd\u0002\u0003", @"(\d+)") + "$");
PluginLog.Information($"LocalString({id}) = '{str}'");
PluginLog.Information($"FloorChanged regex = '{str2}'");

Output:

03:26:11.382 | INF [ECommons] [Splatoon] Enabling script TestScript
03:26:11.382 | INF [ECommons] [Splatoon] LocalString(7270) = 'Floor '
03:26:11.382 | INF [ECommons] [Splatoon] FloorChanged = '^Floor $'

If I write this as a test script, it shows the logic for creating the floor change regex is seemingly not functioning anymore: ```cs uint id = 7270; var str = Svc.Data.GetExcelSheet<LogMessage>()?.GetRow(id)?.Text?.ToString() ?? "Unknown"; var str2 = new Regex("^" + str.Replace("\u0002 \u0003\ufffd\u0002\u0003", @"(\d+)") + "$"); PluginLog.Information($"LocalString({id}) = '{str}'"); PluginLog.Information($"FloorChanged regex = '{str2}'"); ``` Output: ``` 03:26:11.382 | INF [ECommons] [Splatoon] Enabling script TestScript 03:26:11.382 | INF [ECommons] [Splatoon] LocalString(7270) = 'Floor ' 03:26:11.382 | INF [ECommons] [Splatoon] FloorChanged = '^Floor $' ```

Warchaild commented

2023-04-13 00:54:34 +00:00

(Migrated from github.com)

Can confirm, I am also having this issue in PotD

carvelli commented

2023-04-13 07:22:58 +00:00

(Migrated from github.com)

Fixed as of v4.5. Not sure why this broke; it doesn't seem like the underlying LogMessage sheet has changed in any notable way.

This isn't really a change so much in the plugin as in one of the libraries used underneath, I think (version 4.4 has been out for 3 weeks).

Fixed as of v4.5. Not sure why this broke; it doesn't seem like the underlying LogMessage sheet has changed in any notable way. This isn't really a change so much in the plugin as in one of the libraries used underneath, I think (version 4.4 has been out for 3 weeks).

liza referenced this issue from a commit

2023-09-17 20:29:24 +00:00

Fix floor change regex (for pomanders)

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: liza/PalacePal#18