liza
/
PalacePal
1
0
Fork 0
Code Issues 9 Pull Requests Projects 1 Releases 47 Activity

Improve repo exception handling

rendering
Liza 2023-03-08 01:27:10 +01:00
parent c5acb2ca54
commit 1b415d7a7f
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Pal.Client/DependencyInjection/RepoVerification.cs
View File

@ -19,8 +19,12 @@ namespace Pal.Client.DependencyInjection
{ {
chat.Error(string.Format(Localization.Error_WrongRepository, chat.Error(string.Format(Localization.Error_WrongRepository,
"https://github.com/carvelli/Dalamud-Plugins")); "https://github.com/carvelli/Dalamud-Plugins"));
throw new InvalidOperationException(); throw new RepoVerificationFailedException();
} }
} }
internal sealed class RepoVerificationFailedException : Exception
{
}
} }
} }

9
Pal.Client/Plugin.cs
View File

@ -102,12 +102,9 @@ namespace Pal.Client
_rootScopeCompletionSource.SetResult(_rootScope); _rootScopeCompletionSource.SetResult(_rootScope);
_loadState = ELoadState.Loaded; _loadState = ELoadState.Loaded;
} }
catch (ObjectDisposedException e) catch (Exception e) when (e is ObjectDisposedException
{ or OperationCanceledException
_rootScopeCompletionSource.SetException(e); or RepoVerification.RepoVerificationFailedException)
_loadState = ELoadState.Error;
}
catch (OperationCanceledException e)
{ {
_rootScopeCompletionSource.SetException(e); _rootScopeCompletionSource.SetException(e);
_loadState = ELoadState.Error; _loadState = ELoadState.Error;