From a1511055207ac6b7f9e34185768efeb0c6f40c7e Mon Sep 17 00:00:00 2001
From: Liza Carvelli <liza@carvel.li>
Date: Fri, 13 Oct 2023 19:06:17 +0200
Subject: [PATCH] Fix retainers repeating the last venture when out of tasks

We now manually set them to execute a Quick Venture when nothing else is
left to do, instead of relying on AR's behavior.
---
 ARControl/ARControl.csproj             |  2 +-
 ARControl/AutoRetainerControlPlugin.cs | 11 ++++++++---
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/ARControl/ARControl.csproj b/ARControl/ARControl.csproj
index 6033344..d8f1d27 100644
--- a/ARControl/ARControl.csproj
+++ b/ARControl/ARControl.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
         <TargetFramework>net7.0-windows</TargetFramework>
-        <Version>2.2</Version>
+        <Version>2.3</Version>
         <LangVersion>11.0</LangVersion>
         <Nullable>enable</Nullable>
         <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
diff --git a/ARControl/AutoRetainerControlPlugin.cs b/ARControl/AutoRetainerControlPlugin.cs
index da075c8..36ed311 100644
--- a/ARControl/AutoRetainerControlPlugin.cs
+++ b/ARControl/AutoRetainerControlPlugin.cs
@@ -78,9 +78,7 @@ public sealed partial class AutoRetainerControlPlugin : IDalamudPlugin
     private void SendRetainerToVenture(string retainerName)
     {
         var venture = GetNextVenture(retainerName, false);
-        if (venture == QuickVentureId)
-            _autoRetainerApi.SetVenture(0);
-        else if (venture.HasValue)
+        if (venture.HasValue)
             _autoRetainerApi.SetVenture(venture.Value);
     }
 
@@ -264,6 +262,13 @@ public sealed partial class AutoRetainerControlPlugin : IDalamudPlugin
                 _pluginInterface.SavePluginConfig(_configuration);
             }
 
+            // Unsure if this (eventually) will do venture plans you've configured in AutoRetainer, but by default
+            // (with Assign + Reassign) as config options, returning `0` here as suggested in
+            // https://discord.com/channels/1001823907193552978/1001825038598676530/1161295221447983226
+            // will just repeat the last venture.
+            //
+            // That makes sense, of course, but it's also not really the desired behaviour for when you're at the end
+            // of a list.
             return QuickVentureId;
         }
         else