From fb3aa0e0d44e10406d761ed929ea3b7b901481c5 Mon Sep 17 00:00:00 2001
From: Liza Carvelli <liza@carvel.li>
Date: Tue, 20 Aug 2024 02:50:47 +0200
Subject: [PATCH] Update warnings

---
 GatheringPathRenderer/RendererPlugin.cs                |  2 ++
 .../Controller/GameUi/InteractionUiController.cs       |  1 -
 Questionable/Controller/GameUi/LeveUiController.cs     |  4 ++--
 Questionable/Controller/GatheringController.cs         |  3 ---
 Questionable/Controller/Steps/Gathering/DoGather.cs    | 10 ++++++----
 5 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/GatheringPathRenderer/RendererPlugin.cs b/GatheringPathRenderer/RendererPlugin.cs
index f3c52af..b1ec756 100644
--- a/GatheringPathRenderer/RendererPlugin.cs
+++ b/GatheringPathRenderer/RendererPlugin.cs
@@ -238,8 +238,10 @@ public sealed class RendererPlugin : IDalamudPlugin
                                 maximumAngle = x.MaximumAngle.GetValueOrDefault();
                             }
 
+#if false
                             var a = GatheringMath.CalculateLandingLocation(x, 0, 0);
                             var b = GatheringMath.CalculateLandingLocation(x, 1, 1);
+#endif
                             return new List<Element>
                             {
                                 new Element(isCone
diff --git a/Questionable/Controller/GameUi/InteractionUiController.cs b/Questionable/Controller/GameUi/InteractionUiController.cs
index a6f1106..64c1783 100644
--- a/Questionable/Controller/GameUi/InteractionUiController.cs
+++ b/Questionable/Controller/GameUi/InteractionUiController.cs
@@ -63,7 +63,6 @@ internal sealed class InteractionUiController : IDisposable
         QuestData questData,
         IGameGui gameGui,
         ITargetManager targetManager,
-        IFramework framework,
         IPluginLog pluginLog,
         IClientState clientState,
         ILogger<InteractionUiController> logger)
diff --git a/Questionable/Controller/GameUi/LeveUiController.cs b/Questionable/Controller/GameUi/LeveUiController.cs
index 533d5d3..5dbedc7 100644
--- a/Questionable/Controller/GameUi/LeveUiController.cs
+++ b/Questionable/Controller/GameUi/LeveUiController.cs
@@ -76,7 +76,7 @@ internal sealed class LeveUiController : IDisposable
         }
     }
 
-    private unsafe void GuildLevePostSetup(AddonEvent type, AddonArgs args)
+    private void GuildLevePostSetup(AddonEvent type, AddonArgs args)
     {
         var target = _targetManager.Target;
         if (target == null)
@@ -85,8 +85,8 @@ internal sealed class LeveUiController : IDisposable
         if (_questController is { IsRunning: true, NextQuest: { Quest.Id: LeveId } nextQuest } &&
             _questFunctions.IsReadyToAcceptQuest(nextQuest.Quest.Id))
         {
-            var addon = (AddonGuildLeve*)args.Addon;
             /*
+            var addon = (AddonGuildLeve*)args.Addon;
             var atkValues = addon->AtkValues;
 
             var availableLeves = _questData.GetAllByIssuerDataId(target.DataId);
diff --git a/Questionable/Controller/GatheringController.cs b/Questionable/Controller/GatheringController.cs
index 4dfae66..36a09a9 100644
--- a/Questionable/Controller/GatheringController.cs
+++ b/Questionable/Controller/GatheringController.cs
@@ -39,7 +39,6 @@ internal sealed unsafe class GatheringController : MiniTaskController<GatheringC
     private readonly GameFunctions _gameFunctions;
     private readonly NavmeshIpc _navmeshIpc;
     private readonly IObjectTable _objectTable;
-    private readonly IServiceProvider _serviceProvider;
     private readonly ICondition _condition;
     private readonly ILoggerFactory _loggerFactory;
     private readonly IGameGui _gameGui;
@@ -59,7 +58,6 @@ internal sealed unsafe class GatheringController : MiniTaskController<GatheringC
         IObjectTable objectTable,
         IChatGui chatGui,
         ILogger<GatheringController> logger,
-        IServiceProvider serviceProvider,
         ICondition condition,
         IDataManager dataManager,
         ILoggerFactory loggerFactory,
@@ -76,7 +74,6 @@ internal sealed unsafe class GatheringController : MiniTaskController<GatheringC
         _gameFunctions = gameFunctions;
         _navmeshIpc = navmeshIpc;
         _objectTable = objectTable;
-        _serviceProvider = serviceProvider;
         _condition = condition;
         _loggerFactory = loggerFactory;
         _gameGui = gameGui;
diff --git a/Questionable/Controller/Steps/Gathering/DoGather.cs b/Questionable/Controller/Steps/Gathering/DoGather.cs
index 5eb29bd..bc40573 100644
--- a/Questionable/Controller/Steps/Gathering/DoGather.cs
+++ b/Questionable/Controller/Steps/Gathering/DoGather.cs
@@ -1,8 +1,7 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using Dalamud.Game.ClientState.Conditions;
-using Dalamud.Memory;
 using Dalamud.Plugin.Services;
 using FFXIVClientStructs.FFXIV.Client.Game;
 using FFXIVClientStructs.FFXIV.Client.UI;
@@ -140,9 +139,10 @@ internal sealed class DoGather(
         return slots;
     }
 
+    [SuppressMessage("ReSharper", "UnusedParameter.Local")]
     private Queue<EAction> GetNextActions(NodeCondition nodeCondition, List<SlotInfo> slots)
     {
-        uint gp = clientState.LocalPlayer!.CurrentGp;
+        //uint gp = clientState.LocalPlayer!.CurrentGp;
         Queue<EAction> actions = new();
 
         if (!gameFunctions.HasStatus(StatusGatheringRateUp))
@@ -236,8 +236,10 @@ internal sealed class DoGather(
 
     public override string ToString() => $"DoGather{(revisitRequired ? " if revist" : "")}";
 
+    [SuppressMessage("ReSharper", "NotAccessedPositionalProperty.Local")]
     private sealed record SlotInfo(int Index, uint ItemId, int GatheringChance, int BoonChance, int Quantity);
 
+    [SuppressMessage("ReSharper", "NotAccessedPositionalProperty.Local")]
     private sealed record NodeCondition(
         uint CurrentIntegrity,
         uint MaxIntegrity);